Wait for comments to load before finishing init#206
Merged
Conversation
rhansen
force-pushed
the
rhansen-init-race
branch
from
cf529a0 to
e5a9499
Compare
Contributor
rhansen
force-pushed
the
rhansen-init-race
branch
from
e5a9499 to
9d9ad1c
Compare
This should fix "TypeError: Cannot read property 'data' of undefined" in `localizeExistingComments()` if the pad loads quickly.
rhansen
force-pushed
the
rhansen-init-race
branch
from
9d9ad1c to
d1d5397
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix "TypeError: Cannot read property 'data' of undefined" in
localizeExistingComments()if the pad loads quickly.Fixes #197
@tiblu Would you mind testing this? I saw #198, but I believe this is a more comprehensive fix.