Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call for Input: Change Author Username in ERC-5585 #333

Closed
9 tasks done
SamWilsn opened this issue Apr 10, 2024 · 7 comments
Closed
9 tasks done

Call for Input: Change Author Username in ERC-5585 #333

SamWilsn opened this issue Apr 10, 2024 · 7 comments

Comments

@SamWilsn
Copy link
Collaborator

SamWilsn commented Apr 10, 2024

Call for Input

Decision

Do we change the author username @apan to @apan826?

If Affirmed

We merge the pull request ethereum/ERCs#367.

If Rejected

We close ethereum/ERCs#367 without merging.

Method

Rough consensus

Deadline

May 10, 2024

Background

Note that the creator of the pull request is not an author of the proposal. I have not verified the new username.

Checklist

I, the opener of this Call for Input, have completed the following:

  • Filled in a descriptive title.
  • Filled in the "Decision" field.
  • Filled in the "If Affirmed" field.
  • Filled in the "If Rejected" field.
  • Filled in the "Method" field.
  • Filled in the "Deadline" field to be thirty days from creation.
  • Added any relevant background information (or removed the section.)
  • Published a notice in writing to the usual channels frequented by EIP Editors (likely Discord.)
  • Commented on this Call for Input, clearly stating my opinion (or abstention.)
@SamWilsn
Copy link
Collaborator Author

With @fovcao's (original author) approval on ethereum/ERCs#367, I am in favour of merging.

@xinbenlv
Copy link

In favor

@abcoathup
Copy link

abcoathup commented Apr 15, 2024

I'm generally against changing final EIPs. (I don't have a vote)
If this change was to be merged, they should get at least 2, preferably 3 authors to approve.

@travelnotes
Copy link

I am in favor of the update. It makes sense to only update the author's account but not the content of the EIP.

This was referenced Apr 24, 2024
@SamWilsn
Copy link
Collaborator Author

I guess the person making this pull request has withdrawn it. @apan826 @crypto-yus if you're interested in pursuing this, please comment here.

@SamWilsn
Copy link
Collaborator Author

I take that back. I guess it's over here now: ethereum/ERCs#405

@SamWilsn SamWilsn reopened this May 22, 2024
@SamWilsn
Copy link
Collaborator Author

General consensus is to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants