add dispose to StatefulWidget #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! flutter_eval.json is indeed generated, although not automatically yet. I just uncomment this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that StatefulWidget currently lacks a bridge for the dispose method, so I tried to add that.
I found that in addition to modifying the code in flutter_eval, I also need to modify flutter_eval.json to add the dispose declaration structure to the json, otherwise the dart_eval compile compiler will report an error that the symbol is not found.
I can't find flutter_eval.json in flutter_eval, I guess it's probably generated automatically at release time.