Conversation
Add complete DELETE and UPDATE support to MemTable as a reference implementation for the TableProvider DML hooks. Implementation: - `delete_from()`: Evaluate filter predicates, remove matching rows - `update()`: Evaluate filters, apply SET expressions to matching rows - `DmlResultExec`: ExecutionPlan returning affected row count - Correct SQL NULL semantics (NULL predicates preserve rows) Tests (812 lines): - DELETE: basic, all rows, predicates (=, >, AND, OR, LIKE, BETWEEN, IN, NOT IN, IS NULL, IS NOT NULL), NULL handling, functions, types - UPDATE: basic, SET expressions, multi-column, CASE, functions, column references, NULL handling, error cases All sqllogictest tests pass: cargo test --test sqllogictests -- dml_delete dml_update
Now that MemTable supports DELETE and UPDATE, the existing EXPLAIN tests produce physical plans instead of "not implemented" errors. Updated expected output to reflect the new DmlResultExec execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?