Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing log arg #625

Merged
merged 1 commit into from
Sep 7, 2024
Merged

Conversation

robinholzi
Copy link
Collaborator

Motivation

We currently didn't log any trigger evaluation records as the batchtrigger refactoring resulted in a missing argument

@robinholzi robinholzi marked this pull request as ready for review September 7, 2024 22:13
@robinholzi robinholzi self-assigned this Sep 7, 2024
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.63%. Comparing base (c24e24c) to head (5b9baa0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #625   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files         258      258           
  Lines       11274    11274           
=======================================
  Hits         9655     9655           
  Misses       1619     1619           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 7, 2024

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi merged commit b58ed10 into main Sep 7, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants