-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add last interval to BetweenTwoTriggersEvalStrategy #618
Merged
robinholzi
merged 24 commits into
main
from
robinholzi/fix/between-triggers-eval-stragy2
Sep 3, 2024
Merged
fix: Add last interval to BetweenTwoTriggersEvalStrategy #618
robinholzi
merged 24 commits into
main
from
robinholzi/fix/between-triggers-eval-stragy2
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix/between-triggers-eval-stragy2
MaxiBoether
approved these changes
Sep 3, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #618 +/- ##
==========================================
- Coverage 85.73% 85.73% -0.01%
==========================================
Files 258 258
Lines 11248 11254 +6
==========================================
+ Hits 9644 9649 +5
- Misses 1604 1605 +1 ☔ View full report in Codecov by Sentry. |
robinholzi
changed the base branch from
robinholzi/warmup-performance-trigger
to
main
September 3, 2024 15:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As for the time after the last training there's no more training hence the time is not covered in an eval interval, we need to handle this case manually