Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add last interval to BetweenTwoTriggersEvalStrategy #618

Merged
merged 24 commits into from
Sep 3, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

As for the time after the last training there's no more training hence the time is not covered in an eval interval, we need to handle this case manually

@robinholzi robinholzi self-assigned this Sep 3, 2024
@MaxiBoether MaxiBoether marked this pull request as ready for review September 3, 2024 14:16
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.73%. Comparing base (73b487c) to head (56e4914).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...r/internal/eval/strategies/between_two_triggers.py 80.00% 1 Missing ⚠️
...or/internal/pipeline_executor/pipeline_executor.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
- Coverage   85.73%   85.73%   -0.01%     
==========================================
  Files         258      258              
  Lines       11248    11254       +6     
==========================================
+ Hits         9644     9649       +5     
- Misses       1604     1605       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Sep 3, 2024

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi changed the base branch from robinholzi/warmup-performance-trigger to main September 3, 2024 15:04
@robinholzi robinholzi merged commit 6fd0063 into main Sep 3, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants