Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DataLoaderInfo dataclass #606

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

Small quality of life improvement. I haven't integrated the model into all the dataset implementations yet, even though most of the arguments are already in the DataLoaderInfo. I don't want to jump into this rabbit whole just now 😅

@robinholzi robinholzi self-assigned this Aug 29, 2024
@robinholzi robinholzi requested a review from MaxiBoether August 29, 2024 08:29
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.36%. Comparing base (b37fc13) to head (2a95340).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   85.25%   85.36%   +0.11%     
==========================================
  Files         255      255              
  Lines       11154    11155       +1     
==========================================
+ Hits         9509     9523      +14     
+ Misses       1645     1632      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi marked this pull request as ready for review August 29, 2024 13:46
@robinholzi robinholzi requested a review from MaxiBoether August 30, 2024 08:40
@robinholzi robinholzi merged commit cbd1006 into main Aug 30, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants