Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement EnsembleTrigger #597

Merged
merged 11 commits into from
Aug 26, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

As we have had the EnsebleTriggerConfig for quite some time, I have already fully integrated it.

Note:

Support for the new (unmerged) trigger policies PerformanceTrigger and CostTrigger must still be added.

@robinholzi robinholzi self-assigned this Aug 19, 2024
Copy link

codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 95.09804% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (6faf871) to head (71fb4ff).
Report is 2 commits behind head on main.

Files Patch % Lines
...yn/supervisor/internal/triggers/ensembletrigger.py 94.25% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
+ Coverage   85.14%   85.25%   +0.10%     
==========================================
  Files         246      247       +1     
  Lines       10886    10979      +93     
==========================================
+ Hits         9269     9360      +91     
- Misses       1617     1619       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi marked this pull request as ready for review August 19, 2024 19:23
@robinholzi robinholzi requested a review from MaxiBoether August 25, 2024 20:28
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I had a few small comments. I didn't realize this needs some caching logic because in mind I only had en ensemble that triggers if any subtrigger triggers but yeah with an arbitrary strategy such as min n we need this sophisticated logic indeed.

@robinholzi robinholzi merged commit fdfb20e into main Aug 26, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants