-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement EnsembleTrigger
#597
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
+ Coverage 85.14% 85.25% +0.10%
==========================================
Files 246 247 +1
Lines 10886 10979 +93
==========================================
+ Hits 9269 9360 +91
- Misses 1617 1619 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. I had a few small comments. I didn't realize this needs some caching logic because in mind I only had en ensemble that triggers if any subtrigger triggers but yeah with an arbitrary strategy such as min n we need this sophisticated logic indeed.
Motivation
As we have had the
EnsebleTriggerConfig
for quite some time, I have already fully integrated it.Note:
Support for the new (unmerged) trigger policies
PerformanceTrigger
andCostTrigger
must still be added.