Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adjustments for triggering experiments #595

Merged

Conversation

robinholzi
Copy link
Collaborator

@robinholzi robinholzi commented Aug 18, 2024

Bugfixes and Experiment configs

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi self-assigned this Aug 20, 2024
@robinholzi robinholzi changed the base branch from main to robinholzi/feat/hellinger September 1, 2024 08:49
robinholzi and others added 6 commits September 1, 2024 10:51
These are "selection-irrelevant" miscellaneous changes. I will have
another PR for the logic to speed up batch-then-sample.
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 48.33333% with 31 lines in your changes missing coverage. Please review.

Project coverage is 85.71%. Comparing base (4208bef) to head (13f6377).
Report is 1 commits behind head on robinholzi/feat/hellinger.

Files with missing lines Patch % Lines
.../internal/pipeline_executor/evaluation_executor.py 14.28% 24 Missing ⚠️
...or/internal/triggers/utils/model/stateful_model.py 0.00% 4 Missing ⚠️
modyn/common/ftp/ftp_utils.py 0.00% 1 Missing ⚠️
...schema/pipeline/trigger/performance/performance.py 50.00% 1 Missing ⚠️
modyn/evaluator/internal/metrics/f1_score.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           robinholzi/feat/hellinger     #595      +/-   ##
=============================================================
- Coverage                      85.83%   85.71%   -0.13%     
=============================================================
  Files                            257      257              
  Lines                          11184    11213      +29     
=============================================================
+ Hits                            9600     9611      +11     
- Misses                          1584     1602      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinholzi robinholzi marked this pull request as ready for review September 2, 2024 15:07
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, changes as mostly discussed :)

MaxiBoether added a commit that referenced this pull request Sep 2, 2024
@robinholzi robinholzi merged commit dc46b6d into robinholzi/feat/hellinger Sep 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants