feat: Add config models for performance aware triggers #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MaxiBoether
requested changes
Aug 18, 2024
modyn/config/schema/pipeline/trigger/performance/performance.py
Outdated
Show resolved
Hide resolved
…in/feat/performance-aware-policy-config-models
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 84.96% 84.97% +0.01%
==========================================
Files 238 240 +2
Lines 10575 10639 +64
==========================================
+ Hits 8985 9041 +56
- Misses 1590 1598 +8 ☔ View full report in Codecov by Sentry. |
robinholzi
changed the base branch from
robin/refactor/cleanup-for-performance-policy
to
main
MaxiBoether
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our new performance-aware triggers (which are an intermediate step towards cost-aware triggers) need to define the configuration space.
** target branch marks the dependency of the PRs: this PR depends on #588