Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over miscellaneous changes from SIGMOD branch #582

Merged
merged 16 commits into from
Jul 30, 2024

fix?

c5a07de
Select commit
Loading
Failed to load commit list.
Merged

Port over miscellaneous changes from SIGMOD branch #582

fix?
c5a07de
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 30, 2024 in 0s

84.90% (+1.87%) compared to ee1904d

View this Pull Request on Codecov

84.90% (+1.87%) compared to ee1904d

Details

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (ee1904d) to head (c5a07de).

Files Patch % Lines
modyn/models/smallyearbooknet/smallyearbooknet.py 47.82% 12 Missing ⚠️
...ding_encoder_utils/embedding_encoder_downloader.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   83.02%   84.90%   +1.87%     
==========================================
  Files         226      224       -2     
  Lines       10532    10318     -214     
==========================================
+ Hits         8744     8760      +16     
+ Misses       1788     1558     -230     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.