Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add nbstripout #579

Merged
merged 3 commits into from
Jul 25, 2024
Merged

feat: Add nbstripout #579

merged 3 commits into from
Jul 25, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

As we have a couple of Jupyter notebooks in the repo now, let's ensure nobody commits the notebooks without clearing the outputs.

@robinholzi robinholzi self-assigned this Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (0ec6b7c) to head (3825a5a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #579   +/-   ##
=======================================
  Coverage   83.02%   83.02%           
=======================================
  Files         226      226           
  Lines       10532    10532           
=======================================
  Hits         8744     8744           
  Misses       1788     1788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, there seems to be a mypy error from a new mypy version. I wonder whether nbstripout can also be part of the CI? I guess it's better to also enforce this in the CI rather than just use pre commit hooks.

@robinholzi
Copy link
Collaborator Author

Generally LGTM, there seems to be a mypy error from a new mypy version. I wonder whether nbstripout can also be part of the CI? I guess it's better to also enforce this in the CI rather than just use pre commit hooks.

Yep, we can easily run the pre-commit hooks in the CI :) I wanted to wait with this until we enable ruff on the whole code base. Do you intend to merge #487? If yes, I'd rather wait until this is done to avoid conflicts.

@robinholzi robinholzi marked this pull request as ready for review July 25, 2024 20:04
@robinholzi robinholzi merged commit fe37530 into main Jul 25, 2024
26 checks passed
@robinholzi robinholzi deleted the robinholzi/feat/nbstripout branch August 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants