Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow evaluation executor to return evaluation results mixed with success and failure #571

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

XianzheMa
Copy link
Collaborator

No description provided.

@XianzheMa XianzheMa requested a review from robinholzi July 10, 2024 18:26
Copy link
Collaborator

@robinholzi robinholzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.02%. Comparing base (1b5ba0e) to head (63e078c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #571   +/-   ##
=======================================
  Coverage   83.02%   83.02%           
=======================================
  Files         226      226           
  Lines       10531    10531           
=======================================
  Hits         8743     8743           
  Misses       1788     1788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XianzheMa XianzheMa changed the title Allow supervisor to return evaluation results mixed with success and failure Allow evaluation executor to return evaluation results mixed with success and failure Jul 10, 2024
Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@XianzheMa XianzheMa merged commit 55dae26 into main Jul 10, 2024
26 checks passed
@XianzheMa XianzheMa deleted the XianzheMa/fix/empty-interval branch July 10, 2024 20:46
robinholzi pushed a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants