Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small issues in aggregation script #553

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Conversation

MaxiBoether
Copy link
Contributor

@MaxiBoether MaxiBoether commented Jun 28, 2024

  • No debug mode by default
  • Ignore number of evaluation workers in equivalence check
  • Change logic for size check to not throw an exception

@MaxiBoether MaxiBoether requested a review from robinholzi June 28, 2024 08:12
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.84%. Comparing base (59ea026) to head (52bfded).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   82.84%   82.84%           
=======================================
  Files         220      220           
  Lines       10235    10235           
=======================================
  Hits         8479     8479           
  Misses       1756     1756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@MaxiBoether MaxiBoether merged commit a4f167a into main Jul 2, 2024
26 checks passed
@MaxiBoether MaxiBoether deleted the fix/MaxiBoether/aggstuff branch July 2, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants