-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Twin RHO Model Step 2: split the training set and train the twin model #552
Conversation
…e/split-training-set
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #552 +/- ##
==========================================
+ Coverage 82.93% 82.98% +0.04%
==========================================
Files 221 221
Lines 10306 10342 +36
==========================================
+ Hits 8547 8582 +35
- Misses 1759 1760 +1 ☔ View full report in Codecov by Sentry. |
Will review when 547 is merged and the branch is updated |
...ector/internal/selector_strategies/downsampling_strategies/rho_loss_downsampling_strategy.py
Show resolved
Hide resolved
...ector/internal/selector_strategies/downsampling_strategies/rho_loss_downsampling_strategy.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! No big comments, just a couple of nitpicky things
...ector/internal/selector_strategies/downsampling_strategies/rho_loss_downsampling_strategy.py
Outdated
Show resolved
Hide resolved
...ector/internal/selector_strategies/downsampling_strategies/rho_loss_downsampling_strategy.py
Show resolved
Hide resolved
...ector/internal/selector_strategies/downsampling_strategies/rho_loss_downsampling_strategy.py
Show resolved
Hide resolved
...ector/internal/selector_strategies/downsampling_strategies/rho_loss_downsampling_strategy.py
Show resolved
Hide resolved
...ector/internal/selector_strategies/downsampling_strategies/rho_loss_downsampling_strategy.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, on the Optional typing thing I had another comment but feel free to ignore that, it's minor...
Per the title.
The major change is in file modyn/selector/internal/selector_strategies/downsampling_strategies/rho_loss_downsampling_strategy.py