Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twin RHO Model Step 2: split the training set and train the twin model #552

Merged
merged 26 commits into from
Jul 1, 2024

Conversation

XianzheMa
Copy link
Collaborator

@XianzheMa XianzheMa commented Jun 27, 2024

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 96.61017% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.98%. Comparing base (60d3baa) to head (3e9250a).

Files Patch % Lines
...ig/schema/pipeline/sampling/downsampling_config.py 66.66% 1 Missing ⚠️
...pling_strategies/rho_loss_downsampling_strategy.py 98.07% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   82.93%   82.98%   +0.04%     
==========================================
  Files         221      221              
  Lines       10306    10342      +36     
==========================================
+ Hits         8547     8582      +35     
- Misses       1759     1760       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@MaxiBoether
Copy link
Contributor

Will review when 547 is merged and the branch is updated

@XianzheMa XianzheMa requested a review from MaxiBoether July 1, 2024 08:33
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! No big comments, just a couple of nitpicky things

@XianzheMa XianzheMa requested a review from MaxiBoether July 1, 2024 08:46
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, on the Optional typing thing I had another comment but feel free to ignore that, it's minor...

@XianzheMa XianzheMa merged commit cdf1280 into main Jul 1, 2024
26 checks passed
@XianzheMa XianzheMa deleted the XianzheMa/feature/split-training-set branch July 1, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants