Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add unique sequence number for aggregation into supervisor #548

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

We want to be able to average the execution time of pipeline stage executions over multiple pipeline runs to gain more confidence in our results. For that we need sequential identifiers to map the StageLog entries from all logfiles.

@robinholzi robinholzi self-assigned this Jun 24, 2024
@robinholzi robinholzi requested a review from MaxiBoether June 24, 2024 19:36
@robinholzi robinholzi marked this pull request as ready for review June 24, 2024 19:38
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.82%. Comparing base (b9e255e) to head (0abed0d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #548      +/-   ##
==========================================
+ Coverage   82.80%   82.82%   +0.01%     
==========================================
  Files         217      217              
  Lines       10157    10163       +6     
==========================================
+ Hits         8411     8417       +6     
  Misses       1746     1746              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinholzi robinholzi merged commit 59d8ee9 into main Jun 24, 2024
20 checks passed
Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi deleted the robinholzi/feat/stage-log-unique-seq-num branch June 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants