Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refine triggering abstraction #546

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

Let's refine the abstraction for trigger a bit to enable more powerful triggering configuration.

Changes

Note: we will adjust the business logic in the future to use the new abstraction.

  • New configuration models & refinement of existing models
  • move trigger configs in dedicated files

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 93.84615% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (42354cf) to head (1a01977).
Report is 3 commits behind head on main.

Files Patch % Lines
modyn/config/schema/pipeline/trigger/ensemble.py 87.09% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #546      +/-   ##
==========================================
+ Coverage   82.81%   82.83%   +0.02%     
==========================================
  Files         217      220       +3     
  Lines       10152    10196      +44     
==========================================
+ Hits         8407     8446      +39     
- Misses       1745     1750       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robinholzi robinholzi marked this pull request as ready for review June 24, 2024 19:33
@robinholzi robinholzi self-assigned this Jun 24, 2024
@robinholzi robinholzi requested a review from MaxiBoether June 24, 2024 19:33
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM, had a short question on the new field on the data drift trigger

docs/pipeline/TRIGGERING.md Show resolved Hide resolved
docs/pipeline/TRIGGERING.md Show resolved Hide resolved
modyn/config/schema/pipeline/config.py Show resolved Hide resolved
modyn/config/schema/pipeline/trigger/drift.py Show resolved Hide resolved
@robinholzi robinholzi merged commit b1b71c2 into main Jun 24, 2024
26 checks passed
@robinholzi robinholzi deleted the robinholzi/feat/refine-triggering-abstraction branch June 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants