Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow to ignore certain assertion errors #545

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

Sometimes a minimal number of evaluation requests are missing due to undetermined reasons. We want to allow manual inspection during aggregation with the option to ignore certain validation errors.

@robinholzi robinholzi self-assigned this Jun 24, 2024
@robinholzi robinholzi marked this pull request as ready for review June 24, 2024 09:24
@robinholzi robinholzi requested a review from MaxiBoether June 24, 2024 09:24
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.81%. Comparing base (97a2b5f) to head (863afd5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage   82.81%   82.81%           
=======================================
  Files         217      217           
  Lines       10152    10152           
=======================================
  Hits         8407     8407           
  Misses       1745     1745           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi merged commit 42354cf into main Jun 24, 2024
26 checks passed
@robinholzi robinholzi deleted the robinholzi/fix/aggregation-logic branch June 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants