Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ratio_max for presampling strategies #544

Merged
merged 1 commit into from
Jun 22, 2024

Conversation

MaxiBoether
Copy link
Contributor

I realized we also need to set ratio_max for presampling strategies, otherwise they cannot run 12.5% as well.

@MaxiBoether MaxiBoether requested a review from XianzheMa June 22, 2024 19:46
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.31%. Comparing base (4d78544) to head (2be4ea6).

Files Patch % Lines
modyn/config/schema/pipeline/sampling/config.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   82.30%   82.31%           
=======================================
  Files         217      217           
  Lines       10118    10125    +7     
=======================================
+ Hits         8328     8334    +6     
- Misses       1790     1791    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@XianzheMa XianzheMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@MaxiBoether MaxiBoether merged commit bf96bfa into main Jun 22, 2024
20 checks passed
@MaxiBoether MaxiBoether deleted the feature/MaxiBoether/presamplingmaxratio branch June 22, 2024 20:12
Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants