Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ratio_max scaling for downsamplers #541

Merged
merged 4 commits into from
Jun 22, 2024

Conversation

MaxiBoether
Copy link
Contributor

Before, we only were able to enter ratios from 0-100 as percentages for downsamplers. With this PR, we allow scaling by a ratio_max factor.

@MaxiBoether MaxiBoether requested a review from XianzheMa June 22, 2024 11:16
Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.30%. Comparing base (70e2a57) to head (9a51476).

Files Patch % Lines
modyn/config/schema/pipeline/config.py 93.33% 1 Missing ⚠️
...ig/schema/pipeline/sampling/downsampling_config.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #541      +/-   ##
==========================================
+ Coverage   82.29%   82.30%   +0.01%     
==========================================
  Files         217      217              
  Lines       10097    10118      +21     
==========================================
+ Hits         8309     8328      +19     
- Misses       1788     1790       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@XianzheMa XianzheMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxiBoether MaxiBoether merged commit 4d78544 into main Jun 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants