-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record training loss #539
Record training loss #539
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 82.81% 82.80% -0.01%
==========================================
Files 217 217
Lines 10152 10157 +5
==========================================
+ Hits 8407 8411 +4
- Misses 1745 1746 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The loss logic itself is ok but I am confused about the gRPC changes since we explicitly did not want to pass the None arguments because in gRPC there is a difference between passing None and no value at all, if I remember correctly. We had issues before with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. i tried to dig into the grpc optional thing again but could not find my old meeting notes with Francesco. I guess it should be ok
Per the PR title, this PR solves issue #488.