Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record training loss #539

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Record training loss #539

merged 4 commits into from
Jun 24, 2024

Conversation

XianzheMa
Copy link
Collaborator

Per the PR title, this PR solves issue #488.

@XianzheMa XianzheMa requested a review from MaxiBoether June 21, 2024 09:03
Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.80%. Comparing base (42354cf) to head (328be5a).
Report is 2 commits behind head on main.

Files Patch % Lines
...trainer_server/internal/trainer/pytorch_trainer.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   82.81%   82.80%   -0.01%     
==========================================
  Files         217      217              
  Lines       10152    10157       +5     
==========================================
+ Hits         8407     8411       +4     
- Misses       1745     1746       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loss logic itself is ok but I am confused about the gRPC changes since we explicitly did not want to pass the None arguments because in gRPC there is a difference between passing None and no value at all, if I remember correctly. We had issues before with this

modyn/common/grpc/grpc_helpers.py Show resolved Hide resolved
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. i tried to dig into the grpc optional thing again but could not find my old meeting notes with Francesco. I guess it should be ok

@XianzheMa XianzheMa merged commit b9e255e into main Jun 24, 2024
26 checks passed
@XianzheMa XianzheMa deleted the XianzheMa/record-training-loss branch June 26, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants