Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Log commit sha #537

Merged
merged 2 commits into from
Jun 21, 2024
Merged

feat: Log commit sha #537

merged 2 commits into from
Jun 21, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

To be able to link a pipeline rune with the code that has executed it, we want to log the git sha of the last commit in the pipeline logfile.

@robinholzi robinholzi self-assigned this Jun 20, 2024
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

n🍨

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.29%. Comparing base (beb3769) to head (f12a451).

Files Patch % Lines
...yn/supervisor/internal/pipeline_executor/models.py 33.33% 4 Missing ⚠️
modyn/supervisor/internal/utils/git_utils.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #537      +/-   ##
==========================================
- Coverage   82.34%   82.29%   -0.05%     
==========================================
  Files         216      217       +1     
  Lines       10085    10097      +12     
==========================================
+ Hits         8304     8309       +5     
- Misses       1781     1788       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi marked this pull request as ready for review June 20, 2024 22:56
@MaxiBoether MaxiBoether merged commit 3dadeac into main Jun 21, 2024
26 checks passed
@robinholzi robinholzi deleted the robinholzi/fix/log-commit-sha branch June 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants