Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: More sophisticated evaluation logic #534

Merged
merged 22 commits into from
Jun 23, 2024

Conversation

robinholzi
Copy link
Collaborator

@robinholzi robinholzi commented Jun 20, 2024

Motivation

  • Analytics tools showed performance issues when run with multiple big logfiles.
  • Naming ambiguities in plotting logic
  • No support for averaging over multiple runs

Changes

  • Introduce an aggregation tool that transforms multiple pipeline logs into one aggregated (averaged) logfile.
  • move analytics plotting app dataframe state into global variable to not reload/rebuild data every time someone selects another pipeline.
  • Improve performance of dataframe construction from logfile by not concatenating size 1 dataframes but collecting all logs in tuples and then creating dataframes from them.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 89.65517% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.30%. Comparing base (4d78544) to head (dbfbb80).

Files Patch % Lines
...yn/supervisor/internal/pipeline_executor/models.py 88.88% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #534      +/-   ##
==========================================
- Coverage   82.30%   82.30%   -0.01%     
==========================================
  Files         217      217              
  Lines       10118    10146      +28     
==========================================
+ Hits         8328     8351      +23     
- Misses       1790     1795       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi self-assigned this Jun 20, 2024
@robinholzi robinholzi changed the title WIP: fix evaluation plotting feat: More sophisticated evaluation logic Jun 22, 2024
@robinholzi robinholzi marked this pull request as ready for review June 22, 2024 13:41
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work smoothly, for now :-) From my side, we can merge this. Thanks so much for the hard work here, this makes analyzing the results so much easier.

@robinholzi
Copy link
Collaborator Author

Seems to work smoothly, for now :-) From my side, we can merge this. Thanks so much for the hard work here, this makes analyzing the results so much easier.

Thanks @MaxiBoether, great to hear that!

@robinholzi robinholzi merged commit 57803ea into main Jun 23, 2024
26 checks passed
@robinholzi robinholzi deleted the robinholzi/fix/eval-plotting branch June 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants