-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix batch number #533
Fix batch number #533
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
==========================================
+ Coverage 82.31% 82.81% +0.50%
==========================================
Files 217 217
Lines 10125 10124 -1
==========================================
+ Hits 8334 8384 +50
+ Misses 1791 1740 -51 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. My only comment is whether we should log both numbers :)
Previously, we didn't record the number of passed batches correctly:
We use a
batch_number
which is generated purely from enumeration indataloader
. Therefore this number is irrelevant to the number of epochs (only shows how many batches there are in one epoch).A similar issue exists on the iteration on
StB
when we calculate scores class by class. The number of batches passed in the previous class is not correctly accumulated on the current class.This PR fixes it.