-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix evaluation logic #532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. As asked on element, you mentioned before that you might add an increment log in _done, but not sure if that makes sense or not.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #532 +/- ##
=======================================
Coverage 82.49% 82.49%
=======================================
Files 215 215
Lines 10053 10054 +1
=======================================
+ Hits 8293 8294 +1
Misses 1760 1760 ☔ View full report in Codecov by Sentry. |
Motivation
There were some issues that evaluation results weren't collected into the logfile.