Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix evaluation logic #532

Merged
merged 5 commits into from
Jun 20, 2024
Merged

fix: Fix evaluation logic #532

merged 5 commits into from
Jun 20, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

There were some issues that evaluation results weren't collected into the logfile.

@robinholzi robinholzi marked this pull request as ready for review June 20, 2024 10:07
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. As asked on element, you mentioned before that you might add an increment log in _done, but not sure if that makes sense or not.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.49%. Comparing base (55fef7c) to head (60dc728).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   82.49%   82.49%           
=======================================
  Files         215      215           
  Lines       10053    10054    +1     
=======================================
+ Hits         8293     8294    +1     
  Misses       1760     1760           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaxiBoether MaxiBoether merged commit cb0be37 into main Jun 20, 2024
20 checks passed
Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@robinholzi robinholzi deleted the robinholzi/fix/eval-generation branch June 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants