Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unfixed naming inconsistencies #531

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Fix unfixed naming inconsistencies #531

merged 1 commit into from
Jun 20, 2024

Conversation

XianzheMa
Copy link
Collaborator

It turns out my last PR didn't rename all the variables completely, thereby causing CI failures. This PR fixes it.

Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When CI runs through feel free to merge

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (84dac1d) to head (4655326).
Report is 2 commits behind head on main.

Files Patch % Lines
...trainer_server/internal/trainer/pytorch_trainer.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   82.44%   82.49%   +0.04%     
==========================================
  Files         214      215       +1     
  Lines       10042    10053      +11     
==========================================
+ Hits         8279     8293      +14     
+ Misses       1763     1760       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@MaxiBoether MaxiBoether merged commit 55fef7c into main Jun 20, 2024
26 checks passed
@robinholzi
Copy link
Collaborator

what a PR title xD

@XianzheMa XianzheMa deleted the XianzheMa/fix-CI branch June 20, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants