-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward shuffle
to trainer server and measure GPU
#526
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #526 +/- ##
==========================================
+ Coverage 82.43% 82.48% +0.04%
==========================================
Files 214 215 +1
Lines 10038 10049 +11
==========================================
+ Hits 8275 8289 +14
+ Misses 1763 1760 -3 ☔ View full report in Codecov by Sentry. |
shuffle
to trainer server and measure GPU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Xianzhe! I had a nitpicky naming comment, and I would like to always have the stopwatch running, even if we don't properly synchronize cuda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
StartTrainingRequest
, thereby catching the unspecifiedshuffle
.