Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward shuffle to trainer server and measure GPU #526

Merged
merged 11 commits into from
Jun 19, 2024

Conversation

XianzheMa
Copy link
Collaborator

@XianzheMa XianzheMa commented Jun 19, 2024

  1. Add a unit test to how we pack the StartTrainingRequest, thereby catching the unspecified shuffle.
  2. Enable accurate GPU operations measurement.

@XianzheMa XianzheMa changed the title first commit several small improvements Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.48%. Comparing base (e6541d3) to head (e1e3eb5).

Current head e1e3eb5 differs from pull request most recent head 5588511

Please upload reports for the commit 5588511 to get more accurate results.

Files Patch % Lines
...trainer_server/internal/trainer/pytorch_trainer.py 77.41% 7 Missing ⚠️
modyn/common/grpc/grpc_helpers.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   82.43%   82.48%   +0.04%     
==========================================
  Files         214      215       +1     
  Lines       10038    10049      +11     
==========================================
+ Hits         8275     8289      +14     
+ Misses       1763     1760       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@XianzheMa XianzheMa changed the title several small improvements two small improvements Jun 19, 2024
@XianzheMa XianzheMa marked this pull request as ready for review June 19, 2024 14:48
@XianzheMa XianzheMa requested a review from MaxiBoether June 19, 2024 14:54
@MaxiBoether MaxiBoether changed the title two small improvements Forward shuffle to trainer server and measure GPU Jun 19, 2024
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Xianzhe! I had a nitpicky naming comment, and I would like to always have the stopwatch running, even if we don't properly synchronize cuda.

@XianzheMa XianzheMa requested a review from MaxiBoether June 19, 2024 21:45
Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MaxiBoether MaxiBoether merged commit b046892 into main Jun 19, 2024
16 of 18 checks passed
@XianzheMa XianzheMa deleted the XianzheMa/small-improvements branch June 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants