Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multithreaded error handling in storage #524

Merged
merged 9 commits into from
Jun 19, 2024

Conversation

MaxiBoether
Copy link
Contributor

@MaxiBoether MaxiBoether commented Jun 18, 2024

If a thread in the get implementation throws an error, the storage currently dies because C++ does not propagate exceptions to the caller. With this change, we're able to return a gRPC error instead. Also, we throw now in case the file path is empty.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.50%. Comparing base (0a511bb) to head (e07f0ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   82.43%   82.50%   +0.06%     
==========================================
  Files         214      214              
  Lines       10039    10039              
==========================================
+ Hits         8276     8283       +7     
+ Misses       1763     1756       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@MaxiBoether MaxiBoether merged commit 601c2e1 into main Jun 19, 2024
26 checks passed
@MaxiBoether MaxiBoether deleted the fix/MaxiBoether/promisesforexceptions branch June 19, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant