Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Simplify yearbook data generation #523

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

robinholzi
Copy link
Collaborator

Motivation

As yearbook is a rather small dataset, I propose to always store the train, test and all (new) variants.

Changes

  • Always output all three splits of the datasets
  • Use pathlib instead of os.path for cleaner code

@robinholzi robinholzi marked this pull request as ready for review June 18, 2024 16:15
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.34%. Comparing base (beb3769) to head (fee28d5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #523   +/-   ##
=======================================
  Coverage   82.34%   82.34%           
=======================================
  Files         216      216           
  Lines       10085    10085           
=======================================
  Hits         8304     8304           
  Misses       1781     1781           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Copy link
Contributor

@MaxiBoether MaxiBoether left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (if CI runs through)

@robinholzi robinholzi merged commit 70e2a57 into main Jun 21, 2024
26 checks passed
@robinholzi robinholzi deleted the robinholzi/fix/yearbook-generation-splits branch June 29, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants