Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add statistics for CGLM dataset #516

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

MaxiBoether
Copy link
Contributor

@MaxiBoether MaxiBoether commented Jun 18, 2024

We add some statistic collection for the different CGLM variants and helpful plotting scripts.

PR 1/n of porting SIGMOD changes to main. This one should probably not require an indepth review, mostly stuff I needed. Not the prettiest code, but why bother using defaultdicts :D

@MaxiBoether MaxiBoether requested a review from robinholzi June 18, 2024 13:58
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.83%. Comparing base (72ffdca) to head (d6d7b72).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   82.83%   82.83%           
=======================================
  Files         220      220           
  Lines       10232    10232           
=======================================
  Hits         8476     8476           
  Misses       1756     1756           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Copy link
Collaborator

@robinholzi robinholzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the scripts are doing their job :) Maybe we can use notebooks to signal that it's not busyness logic?

benchmark/cglm/analyze_centeredness.py Show resolved Hide resolved
benchmark/cglm/data_generation.py Show resolved Hide resolved
@XianzheMa
Copy link
Collaborator

I'd say let's merge this. It's in the benchmark/ directory; the scripts there are just for quick utility purpose.

It's better to have raw code that helps than not have it.

Let me update the branch, address CI, and merge it when CI passes.

@XianzheMa XianzheMa merged commit 3e86231 into main Jun 26, 2024
26 checks passed
@XianzheMa XianzheMa deleted the feature/MaxiBoether/cglmstats branch June 26, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants