Fix inconsistency on passed number of samples in batch-then-sample mode
#515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XianzheMa
commented
Jun 17, 2024
XianzheMa
commented
Jun 17, 2024
|
Thank you so much for finding this!! |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #515 +/- ##
=======================================
Coverage 82.43% 82.43%
=======================================
Files 214 214
Lines 10038 10038
=======================================
Hits 8275 8275
Misses 1763 1763 ☔ View full report in Codecov by Sentry. |
MaxiBoether
requested changes
Jun 18, 2024
MaxiBoether
requested changes
Jun 18, 2024
XianzheMa
commented
Jun 18, 2024
modyn/trainer_server/internal/dataset/key_sources/local_key_source.py
Outdated
Show resolved
Hide resolved
MaxiBoether
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.