Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for RS2 at the Selector instead of downsampling #466

Open
MaxiBoether opened this issue Jun 3, 2024 · 0 comments
Open

Support for RS2 at the Selector instead of downsampling #466

MaxiBoether opened this issue Jun 3, 2024 · 0 comments

Comments

@MaxiBoether
Copy link
Contributor

In #465, we implement RS2 sampling, which does not need any information from the forward pass. However, the actual training data in RS2 changes each epoch, which the selector currently does not support. We fitted the implementation to the downsampling case, but actually it might be better to extend the selector component to allow updating the TTS if no information from model forward pass is required, since the definition of downsampling more or less is using information from the forward pass.

MaxiBoether added a commit that referenced this issue Jun 4, 2024
This implements the random selection from the [RS2
paper](https://openreview.net/pdf?id=JnRStoIuTe) minus the learning rate
scheduling adjustments.

Note that it is a bit suboptimal to use the downsampling infrastructure
here (#466). We might want to think about making the selector a bit more
dynamic, but for now, this will suffice to run experiments. #462 should
be merged before this is reviewed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant