Skip to content

Conversation

@simonpintarelli
Copy link
Member

  • some distros, at least fedora (*), do not include the cmake config
    file of openblas in their packages
  • remove trailing whitespace in CMakeLists.txt

The following environment variables can be set as a hint to locate openblas:

  • OPENBLAS_DIR
  • OPENBLASROOT

(*): fedora openblas-devel pkg: https://koji.fedoraproject.org/koji/rpminfo?rpmID=20778908


find_package_handle_standard_args(OpenBLAS DEFAULT_MSG LIBSPG_LIBRARIES OPENBLAS_INCLUDE_DIR)

if(LibSPG_FOUND AND NOT TARGET openblas)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is LibSPG_FOUND a typo?

ENV OPENBLASROOT
DOC "openblas libraries list")

find_package_handle_standard_args(OpenBLAS DEFAULT_MSG LIBSPG_LIBRARIES OPENBLAS_INCLUDE_DIR)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here: is LIBSPG_LIBRARIES a typo?

- some distros, at least fedora (*), do not include the cmake config
  file of openblas in their packages

Following environment variables can be set as a hint to locate openblas:
 - `OPENBLAS_DIR`
 - `OPENBLASROOT`

- remove trailing whitespace in `CMakeLists.txt`

(*):  fedora openblas-devel pkg: https://koji.fedoraproject.org/koji/rpminfo?rpmID=20778908
@kabicm kabicm merged commit 1abcb2a into eth-cscs:master Mar 13, 2020
@kabicm
Copy link
Collaborator

kabicm commented Mar 13, 2020

Looks great! Thanks @simonpintarelli!

dbsanfte added a commit to dbsanfte/COSMA that referenced this pull request Oct 19, 2025
Created draft PR eth-cscs#25 to eth-cscs/Tiled-MM for BF16 support:
- 483 lines of new code (bf16_convert kernels + GEMM wrapper)
- Cross-platform (CUDA + ROCm)
- Backward compatible (conditional compilation)
- Comprehensive PR description with performance expectations

PR Status: Draft (pending GPU hardware testing)
PR URL: eth-cscs/Tiled-MM#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants