Fix kinematic tree bug that breaks SMPLH loading #80
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version, the SMPLH model is not loading anymore. This is caused by a change hat was made in the MANO commit:
https://github.com/MarilynKeller/aitviewer/blob/8fb6d4661303579ef04b3bf63ac907dbaecff2ff/aitviewer/renderables/smpl.py#L162C71-L162C86
In the previous version, only the body pose parameters would be passed here, not the hands.
skeleton
only contains the body skeleton, hence the crash.I reverted this change such that only the root orientation and the body pose are passed.
The propose fix does not change the behavior with MANO.
Also, note that I am on python 3.12.3 and it is running with "moderngl-window==2.4.6". Setup.py currently limits the python version to < 3.11.