Fix: handle pack_leaves when adjusting circle rect size#806
Open
xosxos wants to merge 1 commit intoetetoolkit:ete4from
Open
Fix: handle pack_leaves when adjusting circle rect size#806xosxos wants to merge 1 commit intoetetoolkit:ete4from
pack_leaves when adjusting circle rect size#806xosxos wants to merge 1 commit intoetetoolkit:ete4from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened an issue at #805 because switching to ete4 regressed my trees. This was due to a
pack_leavesoption added. Thepack_leavesparameter did not control whether the mainRect was adjusted or not online 271. I propose adding it to the if-else statement. This fixes my issue and, I think, still maintains the usability of thepack_leavesfeature.