Skip to content

Fix issues when installing ete4 on Windows. #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnaudBelcour wants to merge 2 commits into
base: ete4
Choose a base branch
from
Open

Fix issues when installing ete4 on Windows. #783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a648a47
Fix wrong path separator for Windows.
ArnaudBelcour May 16, 2025
255a11b
Fix KeyError 'HOME' on Windows.
ArnaudBelcour May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ete4/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@

# Helper function to define global ETE_* variables.
def ete_path(xdg_var, default):
return os.environ.get(xdg_var, os.environ['HOME'] + default) + '/ete'
return os.environ.get(xdg_var, os.path.expanduser('~') + default) + '/ete'

ETE_DATA_HOME = ete_path('XDG_DATA_HOME', '/.local/share')
ETE_CONFIG_HOME = ete_path('XDG_CONFIG_HOME', '/.config')
Expand Down
4 changes: 2 additions & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
from setuptools import setup, Extension

from glob import glob
from os.path import isfile
from os.path import isfile, sep

from Cython.Build import cythonize


def make_extension(path): # to create cython extensions the way we want
name = path.replace('/', '.')[:-len('.pyx')] # / -> . and remove .pyx
name = path.replace(sep, '.')[:-len('.pyx')] # / -> . and remove .pyx
return Extension(name, [path], extra_compile_args=['-O3'])

setup(
Expand Down