-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Prepare for Bot Api 9.4 #2552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Prepare for Bot Api 9.4 #2552
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ae6e7ad
Add style and icon_custom_emoji_id to InlineKeyboardButton and Keyboa…
ranjitsingha 23e8ab8
Fix spaces
Badiboy 13f771b
Fix spaces
Badiboy a75af38
Fix spaces
Badiboy 337978a
Fix formatting of constructor parameters in types.py
ranjitsingha 196bcb4
Add type hints for icon_custom_emoji_id and style
ranjitsingha 015da7c
Update icon_custom_emoji_id parameter description
ranjitsingha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class-level note for
InlineKeyboardButtonsays “You must use exactly one of the optional fields”, buticon_custom_emoji_idandstyleare additional optional fields meant to be used alongside an action field (e.g.,callback_data/url). As documented now, it reads likestyle/icon_custom_emoji_idare mutually exclusive with the rest, which would be misleading. Please clarify the docstring to scope the exclusivity requirement to the button action fields only.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can only be used if the bot has a Telegram Premium subscription.-> Can only be used if the bot owner has a Telegram Premium subscription.