Merge/foundation release/v1.14 #649
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cmd, core, metrics: always report expensive metrics * core, metrics: report block processing metrics as resetting timer * metrics: update reporter tests
Signed-off-by: Lee Bousfield <ljbousfield@gmail.com>
core: fix deprecation comment
Package filepath implements utility routines for manipulating filename paths in a way compatible with the target operating system-defined file paths. Package path implements utility routines for manipulating slash-separated paths. The path package should only be used for paths separated by forward slashes, such as the paths in URLs
…9223) Co-authored-by: Felix Lange <fjl@twurst.com>
common/math: does not change base parameter
Adds a debug level log if the payload building failed for whatever reason
Co-authored-by: Stefan <stefan@starflinger.eu>
This change fixes a concurrency-issue where JS-tracers were accessing the block-ctx GetHash function in a in parallel, which is not safe.
This change makes use of the following underlying changes to the kzg-libraries in order to avoid passing large things on the stack: - c-kzg: ethereum/c-kzg-4844#393 and - go-kzg: https://github.com/crate-crypto/go-kzg-4844/pull/63
fixes some links in documentation
* core: improve chain rewinding mechanism * core: address comment * core: periodically print progress log * core: address comments * core: fix comment * core: fix rewinding in path * core: fix beyondRoot condition * core: polish code * core: polish code * core: extend code comment * core: stop rewinding if chain is gapped or genesis is reached * core: fix broken tests
tests, appveyor: only execute one in four permutations when flag -short is used Also enable -short flag on all appveyor builds (also ubuntu)
Co-authored-by: tmelhao <tmelhao@gmail.com>
fix(t8n): unexpected `excessBlobGas` shadowed
In https://eips.ethereum.org/EIPS/eip-4788 the name `BEACON_ROOTS_ADDRESS` is used. This change makes geth use the same variable name to avoid confusion.
When we receive a bad NewPayload, we currently emit a lot of data to the logging facilities. This PR makes it so we print less data.
accounts/abi: remove unused err set and check
Since Go 1.22 has deprecated certain elliptic curve operations, this PR removes references to the affected functions and replaces them with a custom implementation in package crypto. This causes backwards-incompatible changes in some places. --------- Co-authored-by: Marius van der Wijden <m.vanderwijden@live.de> Co-authored-by: Felix Lange <fjl@twurst.com>
Date: 2024-06-21 07:57:31-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-06-21 08:02:32-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…ld or method Closed) Date: 2024-06-21 08:05:44-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…ield or method TraceCallMany) PTAL, this probably isn't right. Date: 2024-06-21 08:14:55-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-06-25 07:47:56-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…tate_diff tracer to use prestate_with_diffMode (draft)
Date: 2024-07-22 10:15:21-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Asserts against bad headers were dropped, now they are added again, per status quo. Date: 2024-07-22 18:01:54-06:00 Signed-off-by: meows <b5c6@protonmail.com> core: another BadHashes re-installment Date: 2024-07-22 20:14:54-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-07-22 18:04:36-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-07-22 18:07:37-06:00 Signed-off-by: meows <b5c6@protonmail.com>
The function signature for Finalize and FinalizeAndAssemble has removed uncles, so now they MUST be passed in with the Body. Date: 2024-07-23 08:55:31-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-07-23 11:05:44-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…haling Date: 2024-07-31 16:57:53-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-07-31 17:01:21-06:00 Signed-off-by: meows <b5c6@protonmail.com>
… fix typo in comment for GetEIP4788TransitionTime
Date: 2024-08-07 08:14:25-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-08-07 08:24:00-06:00 Signed-off-by: meows <b5c6@protonmail.com>
For consistency only. Date: 2024-08-07 10:12:47-06:00 Signed-off-by: meows <b5c6@protonmail.com>
With the make..len logic, a slice is allocated with default addr=zero keys, then values are appended ON TOP of those. This is different logic than master version, which appends to an empty slice. This fixes a bug because we dont want a list of zero-address n-precomps long, which will cause the zero-address to be WARM, which it shouldnt be. Date: 2024-08-13 09:17:00-06:00 Signed-off-by: meows <b5c6@protonmail.com>
….14.0 Date: 2024-08-13 10:05:11-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Pending logs were removed in v1.14.0, but core-geth has reverted that commit. See 0f5494e. In particular, the fix in this patch is the installation of backend.pendingLogsFeed.Send(flattenLogs), where before only backend.chainFeed was getting a useless send of the first block. The helper function notifyPending is removed because it was only used in one place and unnecessarily generated a chain. I swap t.Fatalf for t.Errorf because it was more useful to see which subtests failed than it was to halt at the first failure. Date: 2024-08-14 05:48:59-06:00 Signed-off-by: meows <b5c6@protonmail.com>
The engine needed to be wrapped into beacon. Date: 2024-08-14 06:19:10-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-08-19 09:01:03-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Date: 2024-08-19 09:02:12-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…e in other appends (staticcheck) This line was lost in 3a25b7a Date: 2024-08-19 09:08:00-06:00 Signed-off-by: meows <b5c6@protonmail.com>
…ed fields Date: 2024-08-19 11:15:07-06:00 Signed-off-by: meows <b5c6@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges https://github.com/ethereum/go-ethereum/releases/tag/v1.14.0.
The Geth v1.14.0 drops support for running pre-merge networks, so we had a lot of work to merge it in core-geth while preserving the features we needed, especially PoW.
The release also brings a lot of features that you can check at their release page.
This PR has been tested and is ready for merge on master, though we won't merge it yet, as we continue testing it to ensure nothing is missing.