build(deps): upgrade tonic from 0.12 to 0.13.x #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not the primary maintainer, but I don't think this passes when the Additionally, I would personally prefer a feature for each backend. |
|
Thank you for your review @nmooscisco
There are some indeed problems with the compilation, I will fix asap.
Make sense. |
|
There is still some work to do, turn to draft. |
fengys1996
force-pushed
the
build/upgrade_tonic
branch
from
6c557ac to
973172a
Compare
fengys1996
commented
Apr 13, 2025
|
@davidli2010 @nmooscisco ptal |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this pr mainly upgrade some dependencies, include tonic, tower, tonic-build.
Note: In this PR, we choose to use
ringcrypto provider intlsfeature. And we add two additional features:tls-ring,tls-aws-lc.