Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace sort.Slice with slices.Sort, slices.SortFunc #221

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

justlorain
Copy link
Contributor

Replace sort.Slice with slices.Sort and slices.SortFunc.
As mentioned in the comments of sort.Slice, the newer method is more ergonomic and run faster.

@justlorain
Copy link
Contributor Author

/cc @pav-kv PTAL, thanks!

Copy link
Contributor

@pav-kv pav-kv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though you might want to get a review from a maintainer. CC @ahrtr

@pav-kv pav-kv requested a review from ahrtr October 2, 2024 13:47
@ahrtr
Copy link
Member

ahrtr commented Oct 2, 2024

@justlorain could you please signoff the commit?

git rebase HEAD~1 --signoff
git push --force-with-lease origin optimize/replace_sort

Signed-off-by: Lorain <justlorain@qq.com>
@justlorain justlorain force-pushed the optimize/replace_sort branch from 8386a9f to 065fbde Compare October 2, 2024 14:02
@justlorain
Copy link
Contributor Author

@justlorain could you please signoff the commit?

git rebase HEAD~1 --signoff
git push --force-with-lease origin optimize/replace_sort

Done, thanks!

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, justlorain, pav-kv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit d8715c5 into etcd-io:main Oct 2, 2024
10 checks passed
@justlorain justlorain deleted the optimize/replace_sort branch December 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants