build(deps): bump devcontainers/go from dev-1.25-bookworm to dev-1.26-bookworm in /tools/container-images/devcontainer#21752
Conversation
Bumps devcontainers/go from dev-1.25-bookworm to dev-1.26-bookworm. --- updated-dependencies: - dependency-name: devcontainers/go dependency-version: dev-1.26-bookworm dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps .devcontainer/devcontainer.json to dev-1.26-bookworm. Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
cc @ivanvc |
|
@serathius, this worked as expected. We wanted GitHub actions to bump the dev container JSON definition. We decided to switch to the dev container based on tooling and quicker adoption of newer minors. Right, @henrybear327? /ok-to-test |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #21752 +/- ##
==========================================
+ Coverage 70.19% 70.29% +0.09%
==========================================
Files 426 426
Lines 35224 35224
==========================================
+ Hits 24726 24761 +35
+ Misses 9103 9069 -34
+ Partials 1395 1394 -1 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sounds good. |
|
Do we have any tests for devcontainers to detect if bumping image will break it? |
Yes, this correct. Please see the links in comment #21752 (comment) |
We are currently relying on the existing tests on CI for catching issues for now, unless I am missing something. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dependabot[bot], henrybear327, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
But I don't think we're actually testing that the tests run on that specific image. |
4 participants
Bumps devcontainers/go from dev-1.25-bookworm to dev-1.26-bookworm.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)