-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping #19166
base: release-3.4
Are you sure you want to change the base?
[3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping #19166
Conversation
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
Hi @joshuazh-x. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retitle [3.4] Avoid deadlock in etcd.Close when stopping during bootstrapping |
Signed-off-by: Joshua Zhang <joshua.x.zhang@gmail.com>
b1802ac
to
a3bf49b
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, joshuazh-x The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please also add a changelog item for 3.4 (link to this PR) and 3.5 (link to #19167) respectively, thx |
/retest |
Changlog PR #19171 |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
#19150: Backport #19139 to 3.4