Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tls min/max version to grpc proxy #18816

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tjungblu
Copy link
Contributor

This adds the min and max TLS version support from #13506 and #15156 to the grpc proxy.

Fixes #13506

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 68.65%. Comparing base (ee88ecc) to head (c99dcd4).
Report is 10 commits behind head on main.

Current head c99dcd4 differs from pull request most recent head 463eef9

Please upload reports for the commit 463eef9 to get more accurate results.

Files with missing lines Patch % Lines
server/etcdmain/grpc_proxy.go 6.45% 29 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdmain/grpc_proxy.go 14.52% <6.45%> (-0.53%) ⬇️

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18816      +/-   ##
==========================================
- Coverage   68.74%   68.65%   -0.10%     
==========================================
  Files         420      420              
  Lines       35523    35549      +26     
==========================================
- Hits        24422    24407      -15     
- Misses       9673     9706      +33     
- Partials     1428     1436       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee88ecc...463eef9. Read the comment docs.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The change looks good, but unfortunately there is no test cases.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tjungblu
Copy link
Contributor Author

tjungblu commented Nov 1, 2024

happy to add some in a separate PR, because for grpc proxy we have almost nothing 🙀

This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy.

Fixes etcd-io#13506

Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
@tjungblu
Copy link
Contributor Author

tjungblu commented Nov 4, 2024

just added a basic e2e that those flags work for starting the proxy process

@tjungblu
Copy link
Contributor Author

tjungblu commented Nov 4, 2024

/retest

1 similar comment
@jmhbnz
Copy link
Member

jmhbnz commented Nov 7, 2024

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

TLS1.3 support
5 participants