-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tls min/max version to grpc proxy #18816
base: main
Are you sure you want to change the base?
Conversation
98eb3ab
to
3149bcf
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 23 files with indirect coverage changes @@ Coverage Diff @@
## main #18816 +/- ##
==========================================
- Coverage 68.74% 68.65% -0.10%
==========================================
Files 420 420
Lines 35523 35549 +26
==========================================
- Hits 24422 24407 -15
- Misses 9673 9706 +33
- Partials 1428 1436 +8 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The change looks good, but unfortunately there is no test cases.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, tjungblu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
happy to add some in a separate PR, because for grpc proxy we have almost nothing 🙀 |
This adds the min and max TLS version support from etcd-io#13506 and etcd-io#15156 to the grpc proxy. Fixes etcd-io#13506 Signed-off-by: Thomas Jungblut <tjungblu@redhat.com>
3149bcf
to
463eef9
Compare
just added a basic e2e that those flags work for starting the proxy process |
/retest |
1 similar comment
/retest |
This adds the min and max TLS version support from #13506 and #15156 to the grpc proxy.
Fixes #13506
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.