-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow duplicated puts in robustness #18772
base: main
Are you sure you want to change the base?
Conversation
…e to discard Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18772 +/- ##
=======================================
Coverage 68.77% 68.77%
=======================================
Files 420 420
Lines 35508 35508
=======================================
+ Hits 24420 24422 +2
+ Misses 9661 9654 -7
- Partials 1427 1432 +5 Continue to review full report in Codecov by Sentry.
|
… useful to implement patching for non-put Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
c95e8fa
to
b4142a0
Compare
/retest |
ping @ahrtr |
cc @jmhbnz |
Rewrite patching history, so instead of patching only puts by assuming all of them are unique, rather count client calls and only allow patching for writes that were called once.
This is needed to implement Kubernetes like compaction that reuses same key.
cc @ah8ad3 @ahrtr @MadhavJivrajani @henrybear327