Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow duplicated puts in robustness #18772

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

serathius
Copy link
Member

@serathius serathius commented Oct 23, 2024

Rewrite patching history, so instead of patching only puts by assuming all of them are unique, rather count client calls and only allow patching for writes that were called once.

This is needed to implement Kubernetes like compaction that reuses same key.

cc @ah8ad3 @ahrtr @MadhavJivrajani @henrybear327

…e to discard

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.77%. Comparing base (867bd26) to head (83fe6af).
Report is 4 commits behind head on main.

Current head 83fe6af differs from pull request most recent head b4142a0

Please upload reports for the commit b4142a0 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #18772   +/-   ##
=======================================
  Coverage   68.77%   68.77%           
=======================================
  Files         420      420           
  Lines       35508    35508           
=======================================
+ Hits        24420    24422    +2     
+ Misses       9661     9654    -7     
- Partials     1427     1432    +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 867bd26...b4142a0. Read the comment docs.

… useful to implement patching for non-put

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Copy link
Member Author

/retest

@serathius
Copy link
Member Author

ping @ahrtr

@serathius
Copy link
Member Author

cc @siyuanfoundation

@serathius
Copy link
Member Author

cc @jmhbnz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants