Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable gofumpt instead of gofmt linter in contrib, etcdctl and etcdutl #18754

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 19, 2024

Description

enables and fixes gofumpt linter issues in contrib, etcdctl and etcdutl directories

Related to #18955

@k8s-ci-robot
Copy link

Hi @mmorel-35. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.78%. Comparing base (1ee6598) to head (f77a3ab).

Current head f77a3ab differs from pull request most recent head 3ef69d2

Please upload reports for the commit 3ef69d2 to get more accurate results.

Files with missing lines Patch % Lines
etcdctl/ctlv3/command/printer.go 0.00% 3 Missing ⚠️
etcdctl/ctlv3/command/check.go 0.00% 2 Missing ⚠️
etcdutl/etcdutl/snapshot_command.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
etcdctl/ctlv3/command/elect_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/ep_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/lease_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/printer_fields.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/printer_simple.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/printer_table.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/snapshot_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/command/user_command.go 0.00% <ø> (ø)
etcdctl/ctlv3/ctl.go 0.00% <ø> (ø)
etcdutl/ctl.go 0.00% <ø> (ø)
... and 8 more

... and 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18754      +/-   ##
==========================================
+ Coverage   68.70%   68.78%   +0.07%     
==========================================
  Files         420      420              
  Lines       35531    35532       +1     
==========================================
+ Hits        24413    24442      +29     
+ Misses       9687     9661      -26     
+ Partials     1431     1429       -2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee6598...3ef69d2. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Oct 19, 2024

/ok-to-test

@mmorel-35
Copy link
Contributor Author

@ahrtr,

There is no suggested assignee here.
Do you know why ?
Who shall be assigned then ?

@mmorel-35 mmorel-35 force-pushed the contrib/golangci-lint/gofumpt branch from 9791d81 to 79e6169 Compare October 26, 2024 06:18
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35
Copy link
Contributor Author

/assign @ahrtr

@mmorel-35 mmorel-35 force-pushed the contrib/golangci-lint/gofumpt branch from 79e6169 to b519548 Compare November 1, 2024 14:11
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35
Copy link
Contributor Author

/test pull-etcd-integration-1-cpu-amd64

@mmorel-35
Copy link
Contributor Author

/test pull-etcd-integration-2-cpu-amd64

@mmorel-35 mmorel-35 force-pushed the contrib/golangci-lint/gofumpt branch from 97e4699 to e09ecda Compare November 7, 2024 21:20
…tcdutl

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 force-pushed the contrib/golangci-lint/gofumpt branch from e09ecda to 3ef69d2 Compare November 8, 2024 23:37
@mmorel-35
Copy link
Contributor Author

/retest

1 similar comment
@ivanvc
Copy link
Member

ivanvc commented Nov 9, 2024

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mmorel-35

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, mmorel-35

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 0f9c128 into etcd-io:main Nov 9, 2024
32 checks passed
@mmorel-35 mmorel-35 deleted the contrib/golangci-lint/gofumpt branch November 9, 2024 16:41
@mmorel-35 mmorel-35 mentioned this pull request Nov 27, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants