Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove context from top level apply #18675

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

serathius
Copy link
Member

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.90%. Comparing base (9aec291) to head (9c2335d).

Current head 9c2335d differs from pull request most recent head ffdf5f2

Please upload reports for the commit ffdf5f2 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/apply/apply.go 78.02% <100.00%> (ø)
server/etcdserver/apply/apply_auth.go 100.00% <100.00%> (ø)
server/etcdserver/apply/uber_applier.go 86.17% <100.00%> (ø)

... and 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18675      +/-   ##
==========================================
+ Coverage   68.82%   68.90%   +0.08%     
==========================================
  Files         420      420              
  Lines       35540    35540              
==========================================
+ Hits        24459    24489      +30     
+ Misses       9664     9632      -32     
- Partials     1417     1419       +2     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aec291...ffdf5f2. Read the comment docs.

@serathius
Copy link
Member Author

/retest

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment.

Thanks for the change which looks clean.

server/etcdserver/apply/apply.go Show resolved Hide resolved
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit db61a6c into etcd-io:main Oct 4, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants