Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v3compactor): flaky TestPeriodicSkipRevNotChange test by increasing timeout #18668

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

ghouscht
Copy link
Member

@ghouscht ghouscht commented Oct 2, 2024

This should fix #17487, see also comments in issue.

@ahrtr and I were both not sure if this is a change of the test logic (I think it is not) and how the 10ms timeout was initially chosen. Maybe someone else knows more in that regard? Anyway this change makes the test reliable for me.

…ng timeout

Signed-off-by: Thomas Gosteli <thomas.gosteli@protonmail.ch>
@k8s-ci-robot
Copy link

Hi @ghouscht. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Oct 2, 2024

/ok-to-test

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (2c97110) to head (93db8bb).

Current head 93db8bb differs from pull request most recent head 4284a71

Please upload reports for the commit 4284a71 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18668      +/-   ##
==========================================
+ Coverage   68.70%   68.85%   +0.14%     
==========================================
  Files         420      420              
  Lines       35535    35535              
==========================================
+ Hits        24414    24466      +52     
+ Misses       9686     9640      -46     
+ Partials     1435     1429       -6     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c97110...4284a71. Read the comment docs.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ghouscht, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 951fc96 into etcd-io:main Oct 3, 2024
40 checks passed
@ghouscht ghouscht deleted the issue-17487 branch October 3, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

TestPeriodicSkipRevNotChange failed
5 participants