-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support gRPC context propagation in grpcproxy #18012
base: main
Are you sure you want to change the base?
Conversation
Hi @ximenzaoshi. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi, @ximenzaoshi, thanks for your PR. It seems like you didn't sign your commit. Could you please amend your commit and push it again? so the developer certificate of origin (DCO) check passes, i.e:
|
8cc31c0
to
995c623
Compare
…e problem that watch exits when recvLoop exits but sendLoop still running Signed-off-by: ximenzaoshi <wanglu_bx@163.com>
995c623
to
1282b04
Compare
/ok-to-test |
Hi @ximenzaoshi, it would be nice if the PR title could be updated! :) |
/retitle Support gRPC context propagation in grpcproxy |
…e problem that watch exits when recvLoop exits but sendLoop still running
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
Trying to fix #18011.