Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use chain interceptors from grpc package #17922

Merged
merged 1 commit into from
May 3, 2024

Conversation

marefr
Copy link
Contributor

@marefr marefr commented May 1, 2024

Follow up from #17892. Use gRPC chain interceptor functions from grpc package instead of github.com/grpc-ecosystem/go-grpc-middleware (server interceptor chain helpers deprecated in v1.4.0)

Ref #17883

@k8s-ci-robot
Copy link

Hi @marefr. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
@ivanvc
Copy link
Member

ivanvc commented May 1, 2024

/ok-to-test

@marefr
Copy link
Contributor Author

marefr commented May 1, 2024

/test ?

@k8s-ci-robot
Copy link

@marefr: The following commands are available to trigger required jobs:

  • /test pull-etcd-build
  • /test pull-etcd-unit-test
  • /test pull-etcd-verify

The following commands are available to trigger optional jobs:

  • /test pull-etcd-e2e-amd64

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marefr
Copy link
Contributor Author

marefr commented May 1, 2024

/test all

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @marefr

@ahrtr
Copy link
Member

ahrtr commented May 2, 2024

For anyone reference: https://pkg.go.dev/github.com/grpc-ecosystem/go-grpc-middleware#ChainUnaryServer

While this can be useful in some scenarios, it is generally advisable to use google.golang.org/grpc.ChainUnaryInterceptor directly.

and https://pkg.go.dev/github.com/grpc-ecosystem/go-grpc-middleware#ChainStreamServer

While this can be useful in some scenarios, it is generally advisable to use google.golang.org/grpc.ChainStreamInterceptor directly.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the context @ahrtr.
LGTM, thanks @marefr

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr merged commit 3096df2 into etcd-io:main May 3, 2024
45 checks passed
@marefr marefr deleted the chore_grpc_chain_interceptors branch May 3, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants