-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Use chain interceptors from grpc package #17922
Conversation
Hi @marefr. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Marcus Efraimsson <marcus.efraimsson@gmail.com>
05b14e3
to
030066c
Compare
/ok-to-test |
/test ? |
@marefr: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you @marefr
For anyone reference: https://pkg.go.dev/github.com/grpc-ecosystem/go-grpc-middleware#ChainUnaryServer
and https://pkg.go.dev/github.com/grpc-ecosystem/go-grpc-middleware#ChainStreamServer
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Follow up from #17892. Use gRPC chain interceptor functions from grpc package instead of github.com/grpc-ecosystem/go-grpc-middleware (server interceptor chain helpers deprecated in v1.4.0)
Ref #17883