*: cleanup main_test.go #16789
Merged
*: cleanup main_test.go #16789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The etcd-io#15544 has removed the `build_cov` build. And after go1.20, we use `-cover` buildflag to enable coverage exporter. We don't need to maintain main_test.go anymore. ```bash ➜ pwd /home/fuwei/go/src/go.etcd.io/etcd/etcdctl ➜ go build -o /tmp/etcdctl -cover ./ ➜ mkdir /tmp/etcdctl-covdata ➜ GOCOVERDIR=/tmp/etcdctl-covdata /tmp/etcdctl get /health ➜ go tool covdata percent -i=/tmp/etcdctl-covdata go.etcd.io/etcd/etcdctl/v3 coverage: 66.7% of statements go.etcd.io/etcd/etcdctl/v3/ctlv3 coverage: 83.3% of statements go.etcd.io/etcd/etcdctl/v3/ctlv3/command coverage: 15.4% of statements ``` REF: https://go.dev/testing/coverage/ Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
force-pushed
the
cleanup-build-cov
branch
from
79863a1 to
f96000e
Compare
serathius
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The #15544 has removed the
build_covbuild. And after go1.20, we use-coverbuildflag to enable coverage exporter. We don't need to maintain main_test.go anymore.➜ pwd /home/fuwei/go/src/go.etcd.io/etcd/etcdctl ➜ go build -o /tmp/etcdctl -cover ./ ➜ mkdir /tmp/etcdctl-covdata ➜ GOCOVERDIR=/tmp/etcdctl-covdata /tmp/etcdctl get /health ➜ go tool covdata percent -i=/tmp/etcdctl-covdata go.etcd.io/etcd/etcdctl/v3 coverage: 66.7% of statements go.etcd.io/etcd/etcdctl/v3/ctlv3 coverage: 83.3% of statements go.etcd.io/etcd/etcdctl/v3/ctlv3/command coverage: 15.4% of statementsREF: https://go.dev/testing/coverage/
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.